Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle media errors #20

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Handle media errors #20

merged 3 commits into from
Mar 25, 2024

Conversation

neekolas
Copy link
Collaborator

@neekolas neekolas commented Mar 25, 2024 •
edited
Loading

Summary

  • Proxy should pass through non-2xx status codes to the caller for media requests
  • Adds a test to verify

@neekolas neekolas requested a review from alexrisch March 25, 2024 22:02
@neekolas neekolas marked this pull request as ready for review March 25, 2024 22:04
@neekolas Graphite App
Copy link
Collaborator Author

neekolas commented Mar 25, 2024 •
edited
Loading

Merge activity

  • Mar 25, 6:20 PM EDT: @neekolas started a stack merge that includes this pull request via Graphite.
  • Mar 25, 6:21 PM EDT: @neekolas merged this pull request with Graphite.

@neekolas neekolas merged commit d6d6be2 into main Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrisch alexrisch alexrisch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neekolas @alexrisch